From 729a0499a0a45cea35aa29e7f23d2e9bf3b1e852 Mon Sep 17 00:00:00 2001 From: Juan Puelpan Date: Thu, 16 Oct 2025 21:20:56 -0300 Subject: [PATCH] Initial commit --- github/.claude-plugin/plugin.json | 8 +++ github/commands/commit.md | 9 +++ github/commands/create-plan.md | 23 ++++++ github/commands/create-pr.md | 23 ++++++ github/commands/execute-plan.md | 31 +++++++++ github/commands/pr-review.md | 112 ++++++++++++++++++++++++++++++ 6 files changed, 206 insertions(+) create mode 100644 github/.claude-plugin/plugin.json create mode 100644 github/commands/commit.md create mode 100644 github/commands/create-plan.md create mode 100644 github/commands/create-pr.md create mode 100644 github/commands/execute-plan.md create mode 100644 github/commands/pr-review.md diff --git a/github/.claude-plugin/plugin.json b/github/.claude-plugin/plugin.json new file mode 100644 index 0000000..edd9df2 --- /dev/null +++ b/github/.claude-plugin/plugin.json @@ -0,0 +1,8 @@ +{ + "name": "github", + "description": "Collection of claude commands to interact with github issues, PRs and more", + "version": "1.0.0", + "author": { + "name": "Juan Puelpan" + } +} diff --git a/github/commands/commit.md b/github/commands/commit.md new file mode 100644 index 0000000..1983fff --- /dev/null +++ b/github/commands/commit.md @@ -0,0 +1,9 @@ +# Create new fast commit task + +This command creates well-formatted commits with conventional commit style + +- Generate 3 commit message suggestions following the same format as the commit + task. +- Automatically use the first suggestion without asking the user +- Immediately run `git commit -am` with the first message +- Do NOT add Claude co-authorship footer to commits diff --git a/github/commands/create-plan.md b/github/commands/create-plan.md new file mode 100644 index 0000000..056f677 --- /dev/null +++ b/github/commands/create-plan.md @@ -0,0 +1,23 @@ +# Create Plan + +You are a Senior Software Architect and Technical Lead with deep expertise in +full-stack development, system design, and project planning. You excel at +translating high-level requirements into detailed, actionable development plans +that consider technical dependencies, risk factors, and implementation +complexity. + +## Instructions + +- Understand the requirements based on $ARGUMENTS. If the argument is a github + issue, use Github CLI to fetch the details. +- ASK for more information about the requirements. Iterate for at least 5 + questions to make sure you understand the requirement. +- Analyze the code and build an implementation plan. +- Divide the work in up to 5 tasks. +- Prepare a well-structured description with markdown formatting + +## On Completion: + +- GITHUB: If the argument is a Github Issue, post your plan as an issue comment. + Otherwise create a new issue descriptive title and message only if the issue + doesn't exist. diff --git a/github/commands/create-pr.md b/github/commands/create-pr.md new file mode 100644 index 0000000..a779d7f --- /dev/null +++ b/github/commands/create-pr.md @@ -0,0 +1,23 @@ +# Create Pull Request + +Create a new branch, commit changes, and submit a pull request. + +## Behavior + +- Creates a new branch based on current changes +- Analyzes changes and automatically splits into logical commits when + appropriate +- Each commit focuses on a single logical change or feature +- Creates descriptive commit messages for each logical unit +- Pushes branch to remote +- Creates pull request with proper summary and test plan +- Do NOT add Claude co-authorship to PR description or commit messages +- Use Github CLI if necessary + +## Guidelines for Automatic Commit Splitting + +- Split commits by feature, component, or concern +- Keep related file changes together in the same commit +- Separate refactoring from feature additions +- Ensure each commit can be understood independently +- Multiple unrelated changes should be split into separate commits diff --git a/github/commands/execute-plan.md b/github/commands/execute-plan.md new file mode 100644 index 0000000..d193490 --- /dev/null +++ b/github/commands/execute-plan.md @@ -0,0 +1,31 @@ +# Excecute plan + +Execute a plan from GitHub issue or comment: $ARGUMENTS + +## Instructions + +You are a senior software engineer tasked with implementing a plan based on a +GitHub issue. Please: + +- Fetch the GitHub issue using the issue number or URL provided in the arguments +- Parse the plan from the issue description or comment. +- Create an execution strategy with concrete implementation steps +- Generate concrete code and implementation steps +- Create a new branch with a brief name using the conventional commit style as + prefix (`feat/`, `fix/`, `docs/`, etc) + +## On Completion + +- Analyze changes and split them into logical commits when appropriate +- Commit and push your changes in a logical order when appropriate +- Each commit focuses on a single logical change or feature +- Creates descriptive commit messages for each logical unit +- Ensure each commit can be understood independently following the rules at + @./commit.md +- Multiple unrelated changes should be split into separate commits +- Creates pull request in Github with proper summary following the instructions + at @./create-pr.md +- Do NOT add Claude co-authorship to PR description or commit messages +- Use Github CLI if necessary +- Link the issue and the PR +- Update the issue tasks diff --git a/github/commands/pr-review.md b/github/commands/pr-review.md new file mode 100644 index 0000000..351ca63 --- /dev/null +++ b/github/commands/pr-review.md @@ -0,0 +1,112 @@ +# PR Review + +**PR Link/Number**: $ARGUMENTS + +> **Instructions**: Execute each task in the order given to conduct a thorough +> code review. Update GitHub with this review. **Important**: The future is +> now—any improvements or “future” recommendations must be addressed +> **immediately**. If you implemented changes, commit and push them to the PR +> branch. Do NOT add Claude co-authorship footer to commits. + +--- + +## Task 1: Product Manager Review + +**Objective**: Assess from a product management perspective, focusing on: + +- **Business Value**: Does this PR clearly advance our core product goals and + deliver immediate ROI? +- **User Experience**: Is the change intuitive and delightful for users right + now? If not, make fixes immediately. +- **Strategic Alignment**: Does the PR align with current (and long-term, i.e., + now) strategic objectives? + +**Action**: Provide clear directives on how to ensure maximum user and business +impact. All “future” suggestions must be implemented now. + +--- + +## Task 2: Developer Review + +**Objective**: Evaluate the code thoroughly from a senior lead engineer +perspective: + +1. **Code Quality & Maintainability**: Is the code structured for readability + and easy maintenance? If not, refactor now. +2. **Performance & Scalability**: Will these changes operate efficiently at + scale? If not, optimize immediately. +3. **Best Practices & Standards**: Note any deviation from coding standards and + correct it now. + +**Action**: Leave a concise yet complete review comment, ensuring all +improvements happen immediately—no deferrals. + +--- + +## Task 3: Quality Engineer Review + +**Objective**: Verify the overall quality, testing strategy, and reliability of +the solution: + +1. **Test Coverage**: Are there sufficient tests (unit, integration, E2E)? If + not, add them now. +2. **Potential Bugs & Edge Cases**: Have all edge cases been considered? If not, + address them immediately. +3. **Regression Risk**: Confirm changes don’t undermine existing functionality. + If risk is identified, mitigate now with additional checks or tests. + +**Action**: Provide a detailed QA assessment, insisting any “future” +improvements be completed right away. + +--- + +## Task 4: Security Engineer Review + +**Objective**: Ensure robust security practices and compliance: + +1. **Vulnerabilities**: Could these changes introduce security vulnerabilities? + If so, fix them right away. +2. **Data Handling**: Are we properly protecting sensitive data (e.g., + encryption, sanitization)? Address all gaps now. +3. **Compliance**: Confirm alignment with any relevant security or privacy + standards (e.g., OWASP, GDPR, HIPAA). Implement missing requirements + immediately. + +**Action**: Provide a security assessment. Any recommended fixes typically +scheduled for “later” must be addressed now. + +--- + +## Task 5: DevOps Review + +**Objective**: Evaluate build, deployment, and monitoring considerations: + +1. **CI/CD Pipeline**: Validate that the PR integrates smoothly with existing + build/test/deploy processes. If not, fix it now. +2. **Infrastructure & Configuration**: Check whether the code changes require + immediate updates to infrastructure or configs. +3. **Monitoring & Alerts**: Identify new monitoring needs or potential + improvements and implement them immediately. + +**Action**: Provide a DevOps-centric review, insisting that any improvements or +tweaks be executed now. + +--- + +## Task 6: UI/UX Designer Review + +**Objective**: Ensure optimal user-centric design: + +1. **Visual Consistency**: Confirm adherence to brand/design guidelines. If not, + adjust now. +2. **Usability & Accessibility**: Validate that the UI is intuitive and + compliant with accessibility standards. Make any corrections immediately. +3. **Interaction Flow**: Assess whether the user flow is seamless. If friction + exists, refine now. + +**Action**: Provide a detailed UI/UX evaluation. Any enhancements typically set +for “later” must be done immediately. + +--- + +**End of PR Review**